Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get <1.70 Working Again #213

Merged

Conversation

michaelciraci
Copy link
Contributor

Currently, exrs (and as a result, image) does not compile as a dependency for rust <1.70 due to a breaking change with half:

cargo +1.69 test   
    Updating crates.io index
error: package `half v2.3.1` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.69.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p half@2.3.1 --precise ver
where `ver` is the latest version of `half` supporting rustc 1.69.0

The breaking change in half is documented here

This merge requests bounds half to allow compilation again with rust <1.70.

In addition, Cargo.lock should be added to .gitignore since this is a package and not library: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Copy link
Owner

@johannesvollmer johannesvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for taking the time :) I'll prepare the next release

@johannesvollmer johannesvollmer merged commit f356152 into johannesvollmer:master Jul 2, 2023
4 checks passed
@johannesvollmer
Copy link
Owner

johannesvollmer commented Jul 2, 2023

done :)
https://github.com/johannesvollmer/exrs/releases/tag/v1.6.5

as a minor release, this should "automatically" replace any previous versions (if you update your versions in the Cargo.lock)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants