This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
feat: dependencies prefetch #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
dependencies-prefetch
branch
from
2807cde
to
04822c2
Compare
johanneswuerbach
force-pushed
the
dependencies-prefetch
branch
from
04822c2
to
ba3cc81
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating the dependencies can take multiple minutes so allow prefetching dependencies in the background.
This relies on the fact that the dependency query is already using the athena query cache, so running it once per query TTL and relying on the cache for storing the result is enough.
The cache is also used to ensure that not multiple processes are re-running the same query before it actually expired.