Toolbar icon issue99 (incomplete implementation) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the delayed response. As you might have guessed, the main problem is that we're not shipping icon files for all existing emoji (for most we're not even shipping individual images and just one big sprite). If you have generated the icon files (like you've done for I wouldn't really be on board with shipping icon files for all available emoji, but I'd happily take a PR that bundles a certain number of them (maybe 5 or 10) that the user can choose from... The general direction of your code looks good, otherwise! Thanks for your help! Please let me know if you have any other questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I hardcoded customisation of the toolbar icon, and when I saw this issue opened and decided to implemented it properly, I couldn't get it working. Anyway, I wanted to send the code over for the shake of learning and contributing – I might be close to the answer 🙆.
In one hand, this code generates from the gulpfile the files with the wanted emoji for the toolbar and updates the icon on build, while on the other hand, an existing emoji can be chosen and it is stored on the popup.js. I could not find a way to export this value and/or to force the rebuild from the popup.js with this value (I'm not even sure if it'd be possible...).
Thanks for the repository and looking forward your answer!!