Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes / Update states improvement / Update for not connected outputs #114

Merged
merged 13 commits into from
Nov 18, 2020
Merged

Bug Fixes / Update states improvement / Update for not connected outputs #114

merged 13 commits into from
Nov 18, 2020

Conversation

granturism0
Copy link

Hello Johann
Thanks for your work so far!
Since I use the Dingz - Switch myself, I found a problem in my configuration and made some improvements.

  1. Update most of dependencies
  2. Update of output states immediately after button pressed
  3. Show only output which are connected
  4. Bugfix for dimmer 1 status (index 0)

Greetings,
Daniel

@johannrichard
Copy link
Owner

Hi @granturism0,

Thanks for the PR and the contribution. I'll have a look into it, but it might take some time before I can go through and integrate/close it. Thanks for your patience with that.

One thing that caught my eye is the not_connected value of the /api/v1/dimmer_config – I'm quite sure this was not part of the original API but introduced with the v1.2.x FIrmware (or in-between the time when I started work on the plugin – as were other changes to the API). I still need to figure out what that means (and if/how I can compare the latest API to an older version 😁).

In the meantime: would you mind share to post some examples of your config (part. dimmer / input / blinds) so I can understand your particular setup? Thanks.

@johannrichard johannrichard added bug Something isn't working enhancement New feature or request labels Nov 16, 2020
@johannrichard johannrichard added this to In progress in Homebridge Plugin via automation Nov 16, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@granturism0
Copy link
Author

Hi @granturism0,

Thanks for the PR and the contribution. I'll have a look into it, but it might take some time before I can go through and integrate/close it. Thanks for your patience with that.

One thing that caught my eye is the not_connected value of the /api/v1/dimmer_config – I'm quite sure this was not part of the original API but introduced with the v1.2.x FIrmware (or in-between the time when I started work on the plugin – as were other changes to the API). I still need to figure out what that means (and if/how I can compare the latest API to an older version 😁).

In the meantime: would you mind share to post some examples of your config (part. dimmer / input / blinds) so I can understand your particular setup? Thanks.

Hallo @johannrichard
no problem and take your time for the review. I have been running this code for a few days now and for me it fits perfectly so far and the bugs are gone now.
If the "not_connected" was in it before version 1.2.x is not known to me and I don't find this old API anymore. If you want to be on the safe side, we would have to check the API version in the code and check for >1.2.

On my test switch I use the following config:
Switch 1 controls output 1 where I have a non dimmable light on. Output two is deactivated, but I use switch two to control a http-address.
Switch 3 and 4 are occupied by the blind motor.
If you want to test other configs, let me know.

Copy link
Owner

@johannrichard johannrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine.

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/dingzAccessory.ts Show resolved Hide resolved
@johannrichard johannrichard merged commit 67d761e into johannrichard:master Nov 18, 2020
Homebridge Plugin automation moved this from In progress to Done Nov 18, 2020
@johannrichard
Copy link
Owner

If the "not_connected" was in it before version 1.2.x is not known to me and I don't find this old API anymore. If you want to be on the safe side, we would have to check the API version in the code and check for >1.2.

It most certainly wasn't otherwise I would have added it to the type definition already. However, its not a breaking change inso far as you can only set it with newer FIrmwares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants