feat: transparent placeholders option (closes #5) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'm actually working on an updated version of the plugin this very moment. Gonna be using a |
johannschopplich
added a commit
that referenced
this pull request
Jan 5, 2023
Transparency logic by @tobimori
|
I have manually included your changes, since I already was working on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a transparent option to the supplied methods which removes the SVG filter snippet that causes the artificats without comprimising on quality for other generated placeholders.
When not explictly specified, transparency is detected by a new method that looks at each Pixel (roughly loops Pixel Target times) and checks whether they're transparent.