Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Use .env mode files, and kirby in subfolder #51

Closed
wants to merge 9 commits into from

Conversation

Small-Systems
Copy link

  1. Reformatting of vite.config so that .env mode files can be loaded, using loadEnv from Vite, rather than dotenv.
  2. Modified VueKit.php; changed the url returned in the functions assetProd, preloadJson, preloadModule.

The purpose of 2, is that when kirby is in a subfolder the urls will resolve correctly. This is not specific to your install, but I have kirby running in a subfolder on my testing server i.e; dev.domain.com/project.

@johannschopplich
Copy link
Owner

Great PR! Can you look at the two comments, please? Thanks in advance.

@Small-Systems
Copy link
Author

Hi, I don't see any comments, where should I be looking? (I've never done a PR before) Thanks, Luke

@johannschopplich
Copy link
Owner

You should see them above, related to the code changes:

grafik

@Small-Systems
Copy link
Author

That's weird, my conversation looks like this:

Screenshot 2022-10-10 at 11 30 08

site/plugins/kirby-vue-kit/classes/VueKit.php Outdated Show resolved Hide resolved
vite.config.js Outdated Show resolved Hide resolved
@johannschopplich
Copy link
Owner

johannschopplich commented Oct 10, 2022

My bad, didn't request the changes…

johannschopplich added a commit that referenced this pull request Nov 18, 2022
@johannschopplich
Copy link
Owner

Hi there, I have manually merged your feature in 7e4c385, because your feature to deploy Kirby in a subfolder is a separate PR and will have to be tested thoroughly, so it won't break existing installations. Would you mind creating a new PR, thanks in advance!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants