This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 19
Use .env mode files, and kirby in subfolder #51
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great PR! Can you look at the two comments, please? Thanks in advance. |
Hi, I don't see any comments, where should I be looking? (I've never done a PR before) Thanks, Luke |
johannschopplich
suggested changes
Oct 10, 2022
My bad, didn't request the changes… |
johannschopplich
added a commit
that referenced
this pull request
Nov 18, 2022
Hi there, I have manually merged your feature in 7e4c385, because your feature to deploy Kirby in a subfolder is a separate PR and will have to be tested thoroughly, so it won't break existing installations. Would you mind creating a new PR, thanks in advance! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of 2, is that when kirby is in a subfolder the urls will resolve correctly. This is not specific to your install, but I have kirby running in a subfolder on my testing server i.e; dev.domain.com/project.