Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update module options #62

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DamianGlowala
Copy link
Contributor

@DamianGlowala DamianGlowala commented Apr 19, 2024

πŸ”— Linked issue

resolves #59

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds initMode option and changes the purpose of enabled one.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

netlify bot commented Apr 19, 2024

βœ… Deploy Preview for nuxt-gtag ready!

Name Link
πŸ”¨ Latest commit 8755ba1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-gtag/deploys/66229964e4d61600086be4bf
😎 Deploy Preview https://deploy-preview-62--nuxt-gtag.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannschopplich
Copy link
Owner

Great idea. Let's wait until this module has been moved to the @nuxtjs namespace. After the migration, I will release a new major version.

@DamianGlowala
Copy link
Contributor Author

DamianGlowala commented Apr 20, 2024

Sure!

When working on this PR, I was wondering whether it would make sense for this module to expose isInitialized flag (the one which currently is declared in the playground? Let me know if it would bring any value and I can add it :)

@johannschopplich
Copy link
Owner

Yeah, absolutely! Would be a great addition to check if one (or multiple) IDs have been activated already.

@DamianGlowala DamianGlowala marked this pull request as draft April 23, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow conditionally enabling the module
2 participants