Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment runtime config types #63

Conversation

DamianGlowala
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This correctly resolves types for e.g. initMode, where it isn't a general string, but more specifically 'auto' | 'manual'.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

netlify bot commented Apr 19, 2024

βœ… Deploy Preview for nuxt-gtag ready!

Name Link
πŸ”¨ Latest commit be30cab
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-gtag/deploys/66229a487c4a8300083e6def
😎 Deploy Preview https://deploy-preview-63--nuxt-gtag.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannschopplich
Copy link
Owner

Amazing! Let's merge it already to prepare for the next major release.

@johannschopplich johannschopplich merged commit 000c996 into johannschopplich:main Apr 20, 2024
4 checks passed
@DamianGlowala DamianGlowala deleted the fix/runtime-config-types-augmentation branch April 20, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants