Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use safetensors? #25

Closed
johko opened this issue Oct 9, 2023 · 2 comments
Closed

Should we use safetensors? #25

johko opened this issue Oct 9, 2023 · 2 comments
Labels
question Further information is requested

Comments

@johko
Copy link
Owner

johko commented Oct 9, 2023

I wondered if we should add an official recommendation to use the safetensors saving format wherever possible.

But I have to admit, that I'm not that familiar with it, so I don't know how much overhead it would be in cases where we cannot use a HF library like transformers.

@Sookeyy-12 Sookeyy-12 added the question Further information is requested label Oct 10, 2023
@merveenoyan
Copy link
Collaborator

@johko I think it's fine, I don't have any strong opinion 😊

@johko
Copy link
Owner Author

johko commented Oct 11, 2023

ok, I guess it is also not that important for now. We'll just stick to whatever people use for now to keep complexity low

@johko johko closed this as completed Oct 11, 2023
ATaylorAerospace pushed a commit that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants