Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit 4, Introduction: Fusion of Text and Vision #126

Merged
merged 11 commits into from
Dec 25, 2023
Merged

Unit 4, Introduction: Fusion of Text and Vision #126

merged 11 commits into from
Dec 25, 2023

Conversation

snehilsanyal
Copy link
Contributor

Hey everyone 🤗

This PR adds the Introduction chapter on Fusion of Text and Vision for Unit 4: Multimodal Models.
Related to Issue: #54
Already reviewed by: @SuryaKrishna02, @charchit7

Best,
Fusion of Text and Vision Team.

@snehilsanyal
Update introduction.mdx
1ac2e2e 
Add new image links (after merging)
@charchit7
Copy link
Collaborator

One last small edit : add Liaon dataset : https://laion.ai/blog/laion-5b/
This was one of the very big contribution which led to Stable Diffusion.

mmhamdy
mmhamdy reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@mmhamdy mmhamdy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! I really enjoyed reading your intro. I especially liked the parts where you introduce what a modality is and also the part showing example combinations of modalities in real life.

chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
@snehilsanyal
Copy link
Contributor Author

One last small edit : add Liaon dataset : https://laion.ai/blog/laion-5b/ This was one of the very big contribution which led to Stable Diffusion.

Sure @charchit7 I will add this, I also came across some more models like Kosmos-2
Might be good to have a good demo/space for this.

snehilsanyal and others added 2 commits December 18, 2023 19:08
@snehilsanyal @mmhamdy
Minor word change
dab0cb3 
Co-authored-by: Mohammed Hamdy <62081584+mmhamdy@users.noreply.github.com>
@snehilsanyal @mmhamdy
Minor word changes
b126e49 
Co-authored-by: Mohammed Hamdy <62081584+mmhamdy@users.noreply.github.com>
@charchit7
Copy link
Collaborator

Yup, @snehilsanyal nice!

@ratan
Copy link
Collaborator

ratan commented Dec 18, 2023

looking good.@snehilsanyal

merveenoyan
merveenoyan reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool and comprehensive, I only left formatting suggestions!

chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
ratan
ratan reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@ratan ratan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once @merveenoyan's suggestions are fixed, good to go

@snehilsanyal
Style and word changes
1b91376 
Word, style changes, and removed newlines.
Restructured some portions.
@snehilsanyal
Copy link
Contributor Author

Super cool and comprehensive, I only left formatting suggestions!

Done @merveenoyan 🤗

@snehilsanyal
Add dataset
ba3587f 
LAION-5B Dataset in Vision + Text
merveenoyan
merveenoyan approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost ready to merge!

chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
@snehilsanyal
Update introduction.mdx
b6b7fc3 
Add a new example for multimodality
@snehilsanyal
Copy link
Contributor Author

snehilsanyal commented Dec 20, 2023 •
edited
Loading

I think this is almost ready to merge!

Done @merveenoyan 🤗 removed the previous example and added a simpler one 😄

ratan
ratan approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@ratan ratan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can be merged

@snehilsanyal snehilsanyal mentioned this pull request Dec 21, 2023
Open
4 tasks
merveenoyan
merveenoyan approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx Outdated Show resolved Hide resolved
@snehilsanyal @merveenoyan
Update chapters/en/Unit 4 - Mulitmodal Models/introduction.mdx
f270ad6 
Remove comment

Co-authored-by: Merve Noyan <merveenoyan@gmail.com>
mmhamdy
mmhamdy approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@merveenoyan merveenoyan merged commit f383527 into johko:main Dec 25, 2023
@snehilsanyal snehilsanyal deleted the intro-fusion-text-vision branch December 25, 2023 14:33
@snehilsanyal snehilsanyal mentioned this pull request Jan 7, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratan ratan ratan approved these changes

@merveenoyan merveenoyan merveenoyan approved these changes

@mmhamdy mmhamdy mmhamdy approved these changes

@MKhalusova MKhalusova Awaiting requested review from MKhalusova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@snehilsanyal @charchit7 @ratan @merveenoyan @mmhamdy