Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-introduction for Unit 4 Multimodal Models #99

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

snehilsanyal
Copy link
Contributor

Just added a quick pre-intro for Unit 4, all three chapters. Kept in mind the latest outline posted by the groups on the discussion section. Coming up with the introduction chapter soon 馃
First atomic PR for the Issue: #54

Best,
Fusion of Text and Vision Team.
cc: @SuryaKrishna02, @johko, @snknitin

@ricard-inho ricard-inho self-requested a review December 8, 2023 01:27
Word and style changes
Copy link
Contributor

@SuryaKrishna02 SuryaKrishna02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. LGTM

Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, but in general LGTM 馃檪

Probably you will have to iterate over the content of the other teams' sections, as they are created, but I already appreciate that you looked into their outlines and included it here 馃

chapters/en/Unit 4 - Mulitmodal Models/pre-intro.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@ricard-inho ricard-inho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Multi-modality --> Multimodality
Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good! Just left some formatting suggestions that you can commit and we can merge after 馃槉

chapters/en/Unit 4 - Mulitmodal Models/pre-intro.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/pre-intro.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 4 - Mulitmodal Models/pre-intro.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@charchit7 charchit7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Boldface for bullet points.
@snehilsanyal snehilsanyal marked this pull request as ready for review December 12, 2023 05:50
@merveenoyan merveenoyan merged commit d77f92e into johko:main Dec 12, 2023
@snehilsanyal snehilsanyal deleted the pre-intro-fusion-text branch December 25, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants