Skip to content

Commit

Permalink
Changes to WaitForADDomain
Browse files Browse the repository at this point in the history
- BREAKING CHANGE: Refactored the resource to handle timeout better and
  more correctly wait for a specific amount, and at the same time make
  the resource more intuitive to use. This change has replaced parameters
  in the resource (issue dsccommunity#343).
- Now the resource can use built-in `PsDscRunAsCredential` instead of
  specifying the `Credential` parameter (issue dsccommunity#367).
- New parameter `SiteName` can be used to wait for a domain controller
  in a specific site in the domain.
  • Loading branch information
johlju committed Jul 30, 2019
1 parent 1a376f0 commit 02be28d
Show file tree
Hide file tree
Showing 6 changed files with 327 additions and 167 deletions.
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@
`Credential` in the function `Restore-ADCommonObject`
- Removed the alias `DomainAdministratorCredential` from the parameter
`Credential` in the function `Get-ADCommonParameters`
- Added function `Find-DomainController`.
- Added function `Get-CurrentUser` (moved from the resource ADKDSKey).
- Updated all the examples files to be prefixed with the resource
name so they are more easily discovered in PowerShell Gallery and
Azure Automation ([issue #416](https://github.com/PowerShell/ActiveDirectoryDsc/issues/416)).
Expand Down Expand Up @@ -105,7 +107,15 @@
- Added comment-based help ([issue #337](https://github.com/PowerShell/ActiveDirectoryDsc/issues/337)).
- Added integration tests ([issue #348](https://github.com/PowerShell/ActiveDirectoryDsc/issues/348)).
- Changes to WaitForADDomain
- Added comment-based help ([issue #341](https://github.com/PowerShell/ActiveDirectoryDsc/issues/341))
- BREAKING CHANGE: Refactored the resource to handle timeout better and
more correctly wait for a specific amount, and at the same time make
the resource more intuitive to use. This change has replaced parameters
in the resource ([issue #343](https://github.com/PowerShell/ActiveDirectoryDsc/issues/343)).
- Now the resource can use built-in `PsDscRunAsCredential` instead of
specifying the `Credential` parameter ([issue #367](https://github.com/PowerShell/ActiveDirectoryDsc/issues/367)).
- New parameter `SiteName` can be used to wait for a domain controller
in a specific site in the domain.
- Added comment-based help ([issue #341](https://github.com/PowerShell/ActiveDirectoryDsc/issues/341)).
- Changes to ADDomainController
- BREAKING CHANGE: Renamed the parameter `DomainAdministratorCredential`
to `Credential` to better indicate that it is possible to impersonate
Expand Down

0 comments on commit 02be28d

Please sign in to comment.