Closes session in find_first_response #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tldextract/remote.py
Outdated
| @@ -38,7 +38,9 @@ def find_first_response(urls): | |||
| except requests.exceptions.RequestException as ree: | |||
| LOG.error('Exception reading Public Suffix List url ' + url + ' - ' + str(ree) + '.') | |||
| else: | |||
There was a problem hiding this comment.
This doesn't close session if it was opened but there's an exception. I'll switch to using it as a context manager. This should still be readable, without crazy try nesting.
This resolves the warning: tldextract/tldextract.py:278: ResourceWarning: unclosed
john-kurkowski
force-pushed
the
patch-session
branch
from
182f77a
to
9385150
Compare
|
Rebased Atop Latest Upstream Branch (RALUB). |
|
Thanks for tracking this down! CI failures are also on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the warning:
tldextract/tldextract.py:278: ResourceWarning: unclosed