Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch more exceptions when fetching PSL #43

Closed
wants to merge 1 commit into from
Closed

Catch more exceptions when fetching PSL #43

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2013

Hello,

I was having an error with this but reading a bit I found it by httplib except.

Fixed error BadStatusLine: ''
@john-kurkowski
Copy link
Owner

Good catch. This diff unfortunately moves the return into the last except clause and won't work. I'm thinking of catching all Exceptions here anyway.

Until this is fixed, you can also workaround your #42 by upgrading to tldextract 1.2.1.

@john-kurkowski
Copy link
Owner

Fixed. Thank you very much for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant