2.0 #92
Merged
2.0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's good practice. The tests were never dependent on the relationship anyway. Stops distributing tests for real. The tests are run centrally on the GitHub repo anyway.
Drop pickle.
Add JSON support to cached files
Not necessarily for performance, but for reasoning about what the types are, and communicating when they're needed to be that type.
use requests instead of urllib Conflicts: tldextract/tldextract.py
Rather than clutter the source, get to it if it becomes an issue.
…suffix_list_urls: Iterable[str]` This better communicates it tries a sequence of URLs and simplifies code.
Conflicts: CHANGELOG.md
|
LGTM 👍 |
This was referenced Mar 24, 2016
|
Merging now. Will release later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the long-running branch for 2.0. Changes are already enumerated in CHANGELOG.md. Mostly cruft cleanup, no new features. No other changes planned.
If this looks good, let's merge to master and publish 2.0rc1.