More permissions #324
Merged
More permissions #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @!attribute group | ||
| # @return [String] | ||
| attribute(:group, kind_of: String, default: 'consul') | ||
| attribute(:group, kind_of: String, default: lazy { node['consul']['config']['group'] }) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
You're going to need to rebase |
Use the same attributes to provide defaults for consul_definition and consul_watch as are used for consul_config. Consolidated each test suite as a recipe in the consul_spec cookbook to reduce the boilerplate this would have added to kitchen.yml.
kingpong
force-pushed
the
more-permissions
branch
from
6f54e7a
to
0950ae5
Compare
|
Thanks @johnbellone, rebased and updated. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the branch from #323 but goes a step further and uses the configured attributes as defaults for the
consul_definitionandconsul_watchresources. I made this a separate pull request since it wasn't something we discussed in #322.