Prevent consul from writing its own config #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue sous-chefs#322. The consul cookbook makes the Consul config writable by the same user that runs the service, which is unnecessary and could be an attack vector. This commit allows the user to specify a different set of permissions for the configuration directories (/etc/consul) than for the runtime data directory (/var/lib/consul). The config owner still defaults to 'consul' since changing it to root is a breaking change.
Merged
| @@ -20,10 +20,13 @@ class ConsulConfig < Chef::Resource | |||
| attribute(:path, kind_of: String, name_attribute: true) | |||
| # @!attribute owner | |||
| # @return [String] | |||
| attribute(:owner, kind_of: String, default: 'consul') | |||
| attribute(:owner, kind_of: String, default: lazy { node['consul']['config']['owner'] }) | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #322.
The consul cookbook makes the Consul config writable by the same user
that runs the service, which is unnecessary and could be an attack
vector. This commit allows the user to specify a different set of
permissions for the configuration directories (/etc/consul) than for the
runtime data directory (/var/lib/consul).
The config owner still defaults to 'consul' since changing it to root is
a breaking change.