Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully Leave Cluster w/ SIGINT #48

Merged
merged 1 commit into from
Sep 29, 2014
Merged

Gracefully Leave Cluster w/ SIGINT #48

merged 1 commit into from
Sep 29, 2014

Conversation

noazark
Copy link
Contributor

@noazark noazark commented Sep 29, 2014

PR for #47, simple, sweet.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ea22e18 on noazark:consul-stop-signal into a5d9987 on johnbellone:master.

@johnbellone
Copy link
Contributor

Took me a little while to find this but it vaguely mentions it. We may want to add a force-stop at some point for SIGTERM. Nice work.

@johnbellone johnbellone reopened this Sep 29, 2014
johnbellone added a commit that referenced this pull request Sep 29, 2014
Gracefully Leave Cluster w/ SIGINT
@johnbellone johnbellone merged commit 4afbc3e into sous-chefs:master Sep 29, 2014
@noazark
Copy link
Contributor Author

noazark commented Sep 29, 2014

Yeah, I was tempted to add it, but decided force-stop belonged in a different PR. Thanks for merging!

@noazark noazark deleted the consul-stop-signal branch September 29, 2014 01:49
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants