Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extending taxonomy #162

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow extending taxonomy #162

wants to merge 1 commit into from
+27 −2

Conversation

nlemoine
Copy link
Contributor

Existing CPT can be extended. Taxonomies should too.

@johnbillion
Copy link
Owner

Nice one, thanks!

@johnbillion johnbillion added this to the 4.6.0 milestone Mar 27, 2021
@johnbillion johnbillion modified the milestones: 4.6.0, 5.0.0, 5.1.0 Oct 3, 2021
@nlemoine
Copy link
Contributor Author

Hello @johnbillion,

Any chance this might get merged? Registering custom taxonomy with the current state leads to troubles in some situations (causing the add_rewrite_tag to be called twice and messing with some rewrite tag overrides).

I rebased the PR to the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting testing needs docs type:enhancement
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlemoine @johnbillion