Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore admin menu behavior by moving the #qm div into another position via javascript #45

Merged
merged 4 commits into from
Feb 2, 2014

Conversation

barryceelen
Copy link
Sponsor Contributor

The query-monitor div is added to the admin page via the shutdown hook. The resulting markup causes the sidebar to behave awkwardly. Might be a nice idea to move the div into a more favorable position via jQuery?

@johnbillion
Copy link
Owner

I've been thinking about this the last couple of days. The problem I can see is it gives the impression that Query Monitor is outputting its data before the admin footer, which means users might think Query Monitor isn't logging activity that happens in or after the admin footer. This might need a bit more work.

@barryceelen
Copy link
Sponsor Contributor Author

Yes, I see what you mean. I’ve changed the .js so that it removes the absolute positioning on the footer and places the query monitor div right after the footer, which looks more appropriate.

Debug bar positions its info panel over the admin page content, which would be an option as well.
Kinda like the way #qm is added to the bottom of the page though, in stead of hiding the rest of the page, what do you think?

@johnbillion johnbillion merged commit ca06afb into johnbillion:develop Feb 2, 2014
@barryceelen barryceelen deleted the develop branch February 6, 2014 10:29
@barryceelen
Copy link
Sponsor Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants