WP_Error tracker #559
Closed
WP_Error tracker #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new panel which allows you to track the journey that a
WP_Errorobject takes through the code.Requires WordPress 5.6 (see https://core.trac.wordpress.org/ticket/40568).
The instantiation of the error is tracked (specifically, the addition of an error to a
WP_Errorobject is tracked) and then any subsequent calls tois_wp_error()where that error object is passed through it.I'm unsure if this panel is widely useful, but I have found it to be useful if a
WP_Errorinstance "disappears" by, for example, being checked and then turned intoreturn false. This panel allows for part of that investigation to be provided for you as you can see the journey that the error took until it disappeared.This usage pattern of course shouldn't be encouraged, but it's what we have. Use exceptions!
The filtered stack trace is currently quite unreliable. I need to continue working on improvements to the filtering inside
QM_Backtrace.