New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes to allow the API to work with cual-id, UUID format #34
Conversation
def test_create_ids_API(self): | ||
result = list(create_ids(100, 7)) | ||
self.assertTrue(len(str(result[0][0])) < 10) | ||
self.assertTrue(len(str(result[0][1])) > 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a very minor comment, but will you change these to use the ==
operator rather than the greater than less than for the cualid and then check the type for the uuid?
id_length = 7
result = list(create_ids(100, id_length))
self.assertTrue(len(result[0][0]) == id_length)
self.assertTrue(type(result[0][1]) == uuid.UUID)
Thanks @kmckinnis One very minor comment, otherwise looks good! |
@kmckinnis Will you make the changes as per the code block I included in my last comment? |
Sorry I didn't see that part of the email. Didn't hit read more. On Mon, Aug 22, 2016 at 4:29 PM, John Chase notifications@github.com
|
Also uuid.UUID causes a failure as uuid is not defined On Tue, Aug 23, 2016 at 9:56 AM, Kevin McKinnis kmckinnis@biota.com wrote:
|
As said above