This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
[Feature] Always prompt the user before promoting a silver #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the program will automatically promote pieces once they reach the other side of the board. That is almost always desirable. However, it can be strategically advantageous to leave a silver general unpromoted. We can prevent the automatic promotion by toggling 'Ask Before Promotion' in the Options menu, but that has the tedious side-effect of requiring us to answer the prompt for every possible promotion. This patch implements a convenient compromise between the default behavior and prompting for promotion: moving a silver general to the opposite side of the board will always trigger the prompt, even if 'Ask Before Promotion' is disabled. This lets us have automatic promotion for all of the other pieces while also letting us control whether or not we want to promote a silver. Signed-off-by: Eric James Michael Ritz <ejmr@plutono.com>
johncheetham
pushed a commit
that referenced
this pull request
Mar 28, 2015
[Feature] Always prompt the user before promoting a silver
|
Merged Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the program will automatically promote pieces once they
reach the other side of the board. That is almost always desirable.
However, it can be strategically advantageous to leave a silver
general unpromoted. We can prevent the automatic promotion by
toggling 'Ask Before Promotion' in the Options menu, but that has the
tedious side-effect of requiring us to answer the prompt for every
possible promotion.
This patch implements a convenient compromise between the default
behavior and prompting for promotion: moving a silver general to the
opposite side of the board will always trigger the prompt, even if
'Ask Before Promotion' is disabled. This lets us have automatic
promotion for all of the other pieces while also letting us control
whether or not we want to promote a silver.
Signed-off-by: Eric James Michael Ritz ejmr@plutono.com