Add prop to control tooltip placement #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great to me John! Thank you for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22.
tooltipPlacementprop that will let users set their desired dropdown placement.@jeffreykthomas thank you for your research. I had to tweak the actual implementation just a bit by setting the actual placement on the
tippyoptions and also on thepopperoverrides. In my testing, I found that I needed it like this to work.I broke it out into a prop in case users want to adjust this themselves dynamically. The default behavior will be the behavior you brought up in your issue. Which, now that you brought it up, I find to be the correct way - that is, the dropdown should always drop downward pretty much in every case.
Can you please review this pr, then I'll merge it in as a new release at
v.4.1.0.