Fixed bugs found while running ESLint and added tabindex to improve…

… accessibility

.eslintrc

@@ -1,15 +1,19 @@
 {
-  "boss": true,     // true: Tolerate assignments where comparisons would be expected
-  "curly": true,    // true: Require {} for every new block or scope
-  "eqeqeq": true,   // true: Require triple equals (===) for comparison
-  "expr": true,   // true: Require triple equals (===) for comparison
-  "immed": true,    // true: Require immediate invocations to be wrapped in parens e.g. `(function () { } ());`
-  "latedef": false,  // true: Require variables/functions to be defined before being used
-  "newcap": true,   // true: Require capitalization of all constructor functions e.g. `new F()`
-  "noarg": true,    // true: Prohibit use of `arguments.caller` and `arguments.callee`
-  "sub": true,      // true: Tolerate using `[]` notation when it can still be expressed in dot notation
-  "undef": true,    // true: Require all non-global variables to be declared (prevents global leaks)
-  "node": true,     // Node.js
-  "-W117": false,    // true: Ignore `not defined` errors as an example of using a rule (W117) by code.
-  "esversion": 6    // Use ES6 support
+  "env": {
+    "es6": true,
+    "browser": true,
+    "mocha": true,
+    "node": true,
+    "jquery": true
+  },
+  "extends": "eslint:recommended",
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module"
+  },
+  "rules": {
+    "no-console": 0,
+    "no-undef" : 0,
+    "no-case-declarations": 0
+  }
 }

changelog.md

@@ -1,5 +1,10 @@
 ### Version History
 
+*1.2.0 (2017/02/21)*
+
+* Integrated ESLint and fixed some bugs found @ron666
+* Added `tabindex` to buttons to improve accessibility @ron666
+
 *1.1.0 (2017/01/30)*
 
 * Added `preview` plugin that plays/pauses video when hovering it and allows to mute/fade-in/fade-out audio in `video` and `audio` tags @ron666

dist/ads-vast/ads-vast.js

@@ -152,7 +152,6 @@ Object.assign(MediaElementPlayer.prototype, {
 	loadAdTagInfoProxy: function loadAdTagInfoProxy() {
 		var t = this,
 		    protocol = location.protocol,
-		    hostname = location.hostname,
 		    query = 'select * from xml where url="' + encodeURI(t.options.vastAdTagUrl) + '"',
 		    yahooUrl = 'http' + (/^https/.test(protocol) ? 's' : '') + '://query.yahooapis.com/v1/public/yql?format=xml&q=' + query;
 

dist/ads/ads.js

@@ -45,7 +45,7 @@ Object.assign(MediaElementPlayer.prototype, {
 	// true when the user clicks play for the first time, or if autoplay is set
 	adsPlayerHasStarted: false,
 
-	buildads: function buildads(player, controls, layers, media) {
+	buildads: function buildads(player, controls, layers) {
 
 		var t = this;
 
@@ -222,7 +222,7 @@ Object.assign(MediaElementPlayer.prototype, {
 		t.container.trigger('mejsprerollmainstarted');
 	},
 
-	adsAdClick: function adsAdClick(e) {
+	adsAdClick: function adsAdClick() {
 		var t = this;
 
 		if (t.media.paused) {