Don't set .me-plugin width/height to 0 #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing 2.15.0 for upgrade in WordPress, I noticed that all video files played by a plugin were only outputting audio, no video. Reverting mediaelement@53810f5 returned playback to normal. In lieu of reverting, these values can just be changed to `auto`, so that the fix for IE8 will remain.
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 9, 2014
* It is required to set `height` on the parent `.wp-video` wrapper for video * Fixes the play button hover problem in Chrome * Includes my pull request: mediaelement/mediaelement#1273 All changes: mediaelement/mediaelement@2.14.2...master See #29110. Built from https://develop.svn.wordpress.org/trunk@29457 git-svn-id: http://core.svn.wordpress.org/trunk@29235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dxw-deploy
pushed a commit
to dxw/wordpress
that referenced
this pull request
Aug 9, 2014
* It is required to set `height` on the parent `.wp-video` wrapper for video * Fixes the play button hover problem in Chrome * Includes my pull request: mediaelement/mediaelement#1273 All changes: mediaelement/mediaelement@2.14.2...master See #29110. Built from https://develop.svn.wordpress.org/trunk@29457 git-svn-id: http://core.svn.wordpress.org/trunk@29235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dustinrue
pushed a commit
to openfcci/wordpress
that referenced
this pull request
Aug 10, 2014
* It is required to set `height` on the parent `.wp-video` wrapper for video * Fixes the play button hover problem in Chrome * Includes my pull request: mediaelement/mediaelement#1273 All changes: mediaelement/mediaelement@2.14.2...master See #29110. Built from https://develop.svn.wordpress.org/trunk@29457 git-svn-id: http://core.svn.wordpress.org/trunk@29235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
johndyer
added a commit
that referenced
this pull request
Aug 11, 2014
Don't set .me-plugin width/height to 0
lagaines
pushed a commit
to lagaines/wordpress
that referenced
this pull request
Aug 24, 2014
* It is required to set `height` on the parent `.wp-video` wrapper for video * Fixes the play button hover problem in Chrome * Includes my pull request: mediaelement/mediaelement#1273 All changes: mediaelement/mediaelement@2.14.2...master See #29110. git-svn-id: https://develop.svn.wordpress.org/trunk@29457 602fd350-edb4-49c9-b593-d223f7449a82
bakulev
pushed a commit
to bakulev/word-test
that referenced
this pull request
Dec 2, 2014
* It is required to set `height` on the parent `.wp-video` wrapper for video * Fixes the play button hover problem in Chrome * Includes my pull request: mediaelement/mediaelement#1273 All changes: mediaelement/mediaelement@2.14.2...master See #29110. Built from https://develop.svn.wordpress.org/trunk@29457
ale-grosselle
pushed a commit
to ale-grosselle/mediaelement
that referenced
this pull request
Nov 25, 2016
Don't set .me-plugin width/height to 0
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Feb 16, 2017
* It is required to set `height` on the parent `.wp-video` wrapper for video * Fixes the play button hover problem in Chrome * Includes my pull request: mediaelement/mediaelement#1273 All changes: mediaelement/mediaelement@2.14.2...master See #29110. git-svn-id: https://develop.svn.wordpress.org/trunk@29457 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing 2.15.0 for upgrade in WordPress, I noticed that all video files played by a plugin were only outputting audio, no video. Reverting 53810f5 returned playback to normal. In lieu of reverting, these values can just be changed to
auto, so that the fix for IE8 will remain.