Add "mejs-shim" class to all shims to prevent improper resizing #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndyer
added a commit
that referenced
this pull request
Mar 11, 2013
Add "mejs-shim" class to all shims to prevent improper resizing
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Add "mejs-shim" class to all shims to prevent improper resizing
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Add "mejs-shim" class to all shims to prevent improper resizing
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Add "mejs-shim" class to all shims to prevent improper resizing
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Add "mejs-shim" class to all shims to prevent improper resizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case in which foreign iframes (overlay ads) are inserted into MediaElementPlayer's DOM structure. They need to remain a constant size, but there is some code that resizes all
<object>s,<iframe>s, and<embed>s to 100% at times.I've changed this code so every shim is created with a
mejs-shimclass, and they are selected as such, instead of selecting specific kinds of elements.