Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Light style" is white font on white page #1012

Closed
Oberonc opened this issue Apr 4, 2023 · 6 comments
Closed

"Light style" is white font on white page #1012

Oberonc opened this issue Apr 4, 2023 · 6 comments
Labels
bug Something isn't working need info More info needed to reproduce or fix

Comments

@Oberonc
Copy link

Oberonc commented Apr 4, 2023

In the GTK4 branch the only way to actually read the text is to use "Dark Style".
"White Style" is basically a white colored font (you can see there is text there so it isn't a full white) on white page.
"Follow system style" is the same as "White Style".

Is there a way to control the font / page colors ?

  • Foliate version: gtk4 branch
  • OS/Distribution and version: Linux from scratch
  • Desktop environment: GNOME 43
  • Installation method: cloned, installed into a folder under home directory and manually run using "GSETTINGS_SCHEMA_DIR=share/glib-2.0/schemas ./bin/foliate".
    I also tried running in place with same results.
@Oberonc Oberonc added the bug Something isn't working label Apr 4, 2023
@johnfactotum
Copy link
Owner

You can use the inspector (F12) to inspect the CSS styles. Assuming this isn't some weird graphics problem, something is setting the color to white, and Foliate certainly isn't doing that right now.

@johnfactotum johnfactotum added the need info More info needed to reproduce or fix label Apr 8, 2023
@Oberonc
Copy link
Author

Oberonc commented Apr 8, 2023 •
edited
Loading

I guess we can put that under "weird graphic problem".
Under light style the observer itself is a fully white block as seen in the pictures I've attached.

Dark Style is fine:
Screenshot from 2023-04-08 18-38-25

Same region of screen in "Light Style" (or "follow system style") .. not so much:
Screenshot from 2023-04-08 18-38-46

@johnfactotum
Copy link
Owner

Does this still happen?

@johnfactotum
Copy link
Owner

johnfactotum commented Nov 17, 2023 •
edited
Loading

Apparently it does, according to this comment

Nope. Intel igpu. I think it has to do with GTK4. The book is not blank, it's just always white on black even if I choose the light theme in the app. My desktop theme is dark, but you should be able to choose how your book is rendered independently of your desktop theme. The old Foliate app is much better in that respect.

http://disq.us/p/2wlp1x1

Edit: I think I read it wrong. The comment says it's always white on black, not white on white.

@johnfactotum
Copy link
Owner

If anyone can reproduce this, please try the following patch:

diff --git a/src/reader/reader.html b/src/reader/reader.html
index bd78314..51c5c51 100644
--- a/src/reader/reader.html
+++ b/src/reader/reader.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
-<meta name="color-scheme" content="light dark">
 <meta http-equiv="Content-Security-Policy" content="default-src 'self' blob:; script-src 'self'; style-src 'self' blob: 'unsafe-inline'; img-src 'self' blob: data:; connect-src 'self' blob: data:; frame-src blob: data:; object-src blob: data:; form-action 'none';">
 <style>
 html {

@johnfactotum
Copy link
Owner

Closing as works for me/stale for now. Feel free to comment if you're still having the same issue.

@johnfactotum johnfactotum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need info More info needed to reproduce or fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Oberonc @johnfactotum