fix: return value for validateLint (#482)

johnfrench3 · Aug 19, 2020 · 4457109 · 4457109
1 parent fdd7242
commit 4457109
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/lib/landing_session.js b/lib/landing_session.js
@@ -137,8 +137,12 @@ class LandingSession extends Session {
       return true;
     }
 
-    const linted = await runAsync('make', ['lint']);
-    return linted;
+    try {
+      await runAsync('make', ['lint']);
+      return true;
+    } catch {
+      return false;
+    }
   }
 
   async tryCompleteLanding(patch) {
@@ -216,6 +220,8 @@ class LandingSession extends Session {
         '`git node land --continue`.');
         process.exit(1);
       }
+    } else {
+      cli.ok('Lint passed cleanly');
     }
 
     this.startAmending();