Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distillery v1 compatibility #29

Conversation

Hermanverschooten
Copy link
Contributor

As I mentioned in #28 the location of rel has changed.
The signature of the callbacks for Plugin have also changed, they now take 2 params.

I also noticed that if the .deb file exists, it is not overwritten, but the files are added, so I added a remove of the deb-file.

@coveralls
Copy link

Coverage Status

Coverage decreased (-25.7%) to 39.896% when pulling 2904543 on Hermanverschooten:distiller_v1 into b8dd51c on johnhamelink:feature/distillery-support.

@johnhamelink
Copy link
Owner

Thank you for this PR @Hermanverschooten. Would you be able to amend the PR to fix the credo and dogma errors?

@coveralls
Copy link

Coverage Status

Coverage decreased (-25.7%) to 39.896% when pulling 700cfee on Hermanverschooten:distiller_v1 into b8dd51c on johnhamelink:feature/distillery-support.

@coveralls
Copy link

Coverage Status

Coverage decreased (-24.7%) to 40.933% when pulling 51ae5bb on Hermanverschooten:distiller_v1 into b8dd51c on johnhamelink:feature/distillery-support.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 66.154% when pulling 86ee1d2 on Hermanverschooten:distiller_v1 into b8dd51c on johnhamelink:feature/distillery-support.

@johnhamelink johnhamelink merged commit 70d01b2 into johnhamelink:feature/distillery-support Jan 7, 2017
@johnhamelink
Copy link
Owner

Thank you! I think this is probably good enough to be merged into master now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants