New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added codename configuration, added architecture in .deb file name #32
Conversation
Hi @samuelebistoletti, thanks for this!
|
66d1e8a
to
64713dd
Compare
64713dd
to
c3bdea9
Compare
I rebased the the repo with master, now should be ok. |
Hi, Thanks |
Hello, @samuelebistoletti! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
Hey @samuelebistoletti sorry for lack of response - been super busy! Looks like we're good to go (the credo errors are project-wide and need to be fixed in another PR!) JH |
I have made some modifications in order to have .deb packages prepared with distribution codename chained with version, so it can be possible to build the same release for different distribution (ex. with Docker containers). I also added the architecture in the package filename. I also fixed a warning of unused import.