Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codename configuration, added architecture in .deb file name #32

Merged
merged 4 commits into from Mar 2, 2017

Conversation

samuelebistoletti
Copy link
Contributor

I have made some modifications in order to have .deb packages prepared with distribution codename chained with version, so it can be possible to build the same release for different distribution (ex. with Docker containers). I also added the architecture in the package filename. I also fixed a warning of unused import.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.154% when pulling 66d1e8a on samuelebistoletti:master into a872c69 on johnhamelink:master.

@johnhamelink
Copy link
Owner

Hi @samuelebistoletti, thanks for this!

  • Can you rebase this PR against master so your previous work on Systemd isn't part of this PR?
  • Please excuse my ignorance, but can you describe to the uninitiated the use-case for a codename and what makes it different from a version number?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.154% when pulling 64713dd on samuelebistoletti:master into a872c69 on johnhamelink:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.154% when pulling c3bdea9 on samuelebistoletti:master into a872c69 on johnhamelink:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.154% when pulling 36da394 on samuelebistoletti:master into a872c69 on johnhamelink:master.

@samuelebistoletti
Copy link
Contributor Author

I rebased the the repo with master, now should be ok.
I also added some details to explain codename on the README.

@samuelebistoletti
Copy link
Contributor Author

Hi,
any news about the possibility to merge that?

Thanks

@sourcelevel-bot
Copy link

Hello, @samuelebistoletti! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.154% when pulling 06cde16 on samuelebistoletti:master into a872c69 on johnhamelink:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.154% when pulling 282b92a on samuelebistoletti:master into a872c69 on johnhamelink:master.

@johnhamelink
Copy link
Owner

Hey @samuelebistoletti sorry for lack of response - been super busy! Looks like we're good to go (the credo errors are project-wide and need to be fixed in another PR!)

JH

@johnhamelink johnhamelink merged commit dd00130 into johnhamelink:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants