Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20 version #179

Closed
MrFire24 opened this issue Jun 23, 2023 · 6 comments
Closed

1.20 version #179

MrFire24 opened this issue Jun 23, 2023 · 6 comments

Comments

@MrFire24
Copy link

No description provided.

@zdwolfe
Copy link

zdwolfe commented Jun 25, 2023

For anyone looking for a 1.20 workaround for bobby, until (if ever) it is officially supported, you can apply a small diff and build it yourself, it works great.

git checkout 87ecd40

Then make the diff:

diff --git a/gradle.properties b/gradle.properties
index 8eab32d..249b4ae 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -2,8 +2,8 @@ org.gradle.jvmargs=-Xmx2G

 # Fabric Properties
        # check these on https://fabricmc.net/develop
-       minecraftVersion=1.20.1
-       yarnMappings=1.20.1+build.1
+       minecraftVersion=1.20
+       yarnMappings=1.20+build.1
        loaderVersion=0.14.21

 # Mod Properties
@@ -19,7 +19,7 @@ org.gradle.jvmargs=-Xmx2G
        # modrinth.token = ***

 # Dependencies
-       fabricApiVersion = 0.83.0+1.20.1
+       fabricApiVersion = 0.83.0+1.20
        configurateVersion = 4.1.2
        geantyrefVersion = 1.3.13
        hoconVersion = 1.4.2
diff --git a/src/main/resources/fabric.mod.json b/src/main/resources/fabric.mod.json
index fcfc7f3..a01b15b 100644
--- a/src/main/resources/fabric.mod.json
+++ b/src/main/resources/fabric.mod.json
@@ -32,7 +32,7 @@

   "depends": {
     "fabricloader": ">=0.14.17",
-    "minecraft": "~1.20.1"
+    "minecraft": "~1.20"
   },
   "suggests": {
     "cloth-config2": "^${clothConfigVersion}",

..and compile with the below commands, the jar will be compiled to build/libs/bobby-5.0.0.jar

./gradlew build

...or if your machine is not set up for java dev, try:

docker run --volume ./:/bobby  --workdir /bobby -it public.ecr.aws/amazoncorretto/amazoncorretto:17 /bobby/gradlew build

@allanonmage
Copy link

What is the bug that this fixes? They have a 1.20 version posted on Modrinth that was posted on 6/13

@zdwolfe
Copy link

zdwolfe commented Jun 25, 2023

The bobby-5.0.0 version you're referring (link) to only supports 1.20.1. Launching bobby-5.0.0 with minecraft 1.20 (not 1.20.1) crashes with an incompatible version error.

@Mugwump-84
Copy link

Would love for a 1.20 version too! Lots of servers haven't updated to 1.20.1

@Johni0702
Copy link
Owner

I am not aware of any legitimate reason for anyone to use 1.20 at this point (or really any point until very shortly after release).
1.20.1 clients can connect to 1.20 servers and vice versa if you weren't aware.

@Johni0702 Johni0702 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
@Johni0702
Copy link
Owner

Duplicate of #177

@Johni0702 Johni0702 marked this as a duplicate of #177 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants