Flexible forceReload and renderAjax #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync with master
…ler generator and allow for more flexible use of forceReload parameter.
…d of renderPartial.
…r forceReload = true. Fixed spelling typo of 'defauls'.
Closed
|
Can you resolved this pull request for me. I will merge when you resolved |
…ustom Conflicts: src/assets/ModalRemote.min.js
|
Hi John, the pull request has been resolved. Also ModalRemote.min.js has been regenerated with the fix from merge request #38. |
johnitvn
added a commit
that referenced
this pull request
Nov 15, 2015
Flexible forceReload and renderAjax
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved 'forceReload' ID logic from Javascript to PHP to allow refreshing a different Pjax container (making ModalRemote.js more generic). For backwards compatibility kept 'forceReload = true' functionality to target by default '#crud-datatable-pjax'.
Changed renderPartial to renderAjax to allow for CSS and JS updates in modal content (needed to handle specific JS based widgets).
Enhanced english message for bulk button when no selection is made.
Fixed typo in modal remote ID ajaxCrudModal (kept it backwards compatible).
Fixed typo 'defauls' in Javascript parameters.
Javascripts have been re-minified with http://closure-compiler.appspot.com/ from Google.