Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent redirect away from wp-login.php when logging out #1

Merged
merged 1 commit into from
Jul 26, 2015

Conversation

userabuser
Copy link
Collaborator

Simply by checking whether or not the action "wp_logout" was fired prior to verifying the nonce will prevent the user from being redirected to the result of network_home_url() when logging out.

This PR is in relation to one of the adverse effects listed on the main repository page:

When a user signs out, they are redirected back to the root of the site rather than wp-login.php. This is because the nonce used by the previously signed-in user does not match the nonce of the now signed-out user, Brutus (correctly) detects a mismatch, and bounces the user away from wp-login.php. This could be improved, but I haven't spent enough time trying to unwind the redirection dance here.

Simply by checking whether or not the action "wp_logout" was fired prior to verifying the nonce will prevent the user from being redirected to the result of network_home_url() when logging out.
JJJ added a commit that referenced this pull request Jul 26, 2015
Prevent redirect away from wp-login.php when logging out
@JJJ JJJ merged commit 300655f into JJJ:master Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants