Spec fixes #249
Merged
Spec fixes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and fix package name references, to use the miller package name (as is done on other distributions). Signed-off-by: Stephen Kitt <steve@sk2.org>
|
Thanks @skitt !! I'll hold off on merging because you asked, but I have no issues with the changes. :) |
* Drop unused sections and directives: Group, Buildroot, %clean, %defattr. * Use the correct license short name (BSD). * Add an explicit build-dependency on gcc. * Don't delete the buildroot. * Use macros where appropriate: %make_build (with parallel builds), %make_install. * Install the license and README. * Don't hard-code the manpage compression extension. * Add version numbers in the changelog, and fix an invalid date. * Add empty lines between each changelog entry. Signed-off-by: Stephen Kitt <steve@sk2.org>
Thanks! There were two remaining issues, the updated PR is ready to go whenever you are. |
|
thanks @skitt !!!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the .spec file up to current standards (see https://docs.fedoraproject.org/en-US/packaging-guidelines/ for details).
Please don’t merge this yet, it’s still undergoing review.