Improve type-inference performance #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
added a commit
that referenced
this pull request
Dec 27, 2021
johnkerl
added a commit
that referenced
this pull request
Dec 27, 2021
johnkerl
added a commit
that referenced
this pull request
Dec 27, 2021
johnkerl
added a commit
that referenced
this pull request
Dec 27, 2021
johnkerl
added a commit
that referenced
this pull request
Dec 27, 2021
johnkerl
added a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is approximately an 34% performance improvement. The idea is to be a bit more careful in inspecting strings -- such as CSV fields -- to see if they represent int/float/string. Before this we were using built-in library functions, which were nice and simpler. However this was using some expensive things to answer simple questions, including an is-octal regex on every single type-infer.