Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for stdlib #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

wolfaba
Copy link

@wolfaba wolfaba commented May 6, 2024

No description provided.

@johnlawerance
Copy link
Owner

Hey @wolfaba thanks for the PR. I haven't maintained this project for a while. Have you already tested these changes and if so would you perhaps be willing to additionally prep some other bits to prepare it for a new forge release since it is currently slated for deprecation? E.g. Updating the readme, compatibility info, any dependencies, etc?

@wolfaba
Copy link
Author

wolfaba commented May 13, 2024

Hello @johnlawerance ,
I have tested it on our running instance and puppet did not change anything, so I presume everything is configured same way as before and it should be - I have just changed the values validation, I made no functional change.
In fact, I am no puppet developer. I have made just this required change, so I am not sure about dependencies and compatibility.
Thank you.
Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants