Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to construct a new WeatherAPI instance with credentials #12

Open
alexanderdean opened this issue Jul 10, 2014 · 4 comments
Open

Comments

@alexanderdean
Copy link

Because reading a WeatherAPI.properties on the classpath is too inflexible.

@johnluetke johnluetke added this to the Future milestone Jul 12, 2014
@johnluetke
Copy link
Owner

Does the changes introduced in 3454682 solve this for you?

@johnluetke johnluetke added Java and removed Java labels Jul 12, 2014
@alexanderdean
Copy link
Author

It's definitely more flexible but I'd prefer an explicit constructor:

WeatherAPI instance = new WeatherAPI(credentials, lruCacheSize, etc)

@johnluetke
Copy link
Owner

My only reservation with an explicit constructor is all the overloading that would need to be done for different sets of parameters. Some kind of config object that can be passed in would solve this, however.

@alexanderdean
Copy link
Author

As a quick heads-up - Snowplow wintern @AALEKH is working on a PR to add this functionality. We need this to deliver the weather enrichment in Snowplow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants