Fix Conan profile in deploy script #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses `git ls-files` -- instead of `find` -- to ensure that files under
.git subdirectory are ignored
- (This becomes a problem if any files under /.git/ match criteria for
being a script.)
- uses file mode bits and shebang of script file -- instead of file
extensions -- to test whether each file is a bash script
- hypothesis is that since switch to using Conan to build CNL, unit tests are now build during deplotment and this highlights that Conan isn't correctly configured
- Executables shouldn't need a file extension; they're already marked as executable. - .sh should be reserved for files that are run using the `source` command under the sh shell -- not executable files that use the bash shell.
johnmcfarlane
force-pushed
the
fix-conan-profile-in-deploy.sh
branch
from
afb8aa3
to
1d0ee4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy script broke because
conan buildbuilds everything and script wasn't set up to build. (Specifically, it needed to set settings.compiler.libcxx to libstdc++11 in the profile.)Along the way, the branch name for this MR, fix-conan-profile-in-deploy.sh highlighted brittleness in the shellcheck script which provided an opportunity to implement some long-overdue improvements to Bash scripts.