Signed multiprecision used bits #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes - addresses [issue#67](#67) - pass by `const&` to avoid costly copies of (potentially) large objects - do not rely on `sizeof(I)*CHAR_BIT` to measure bit width - use `cnl::digits` instead
- number of bits (width) was being reported for the number of digits for a signed boost::multiprecision::cpp_int_backend type - sign bit was being added twice to the width of signed, multiprecision ints that use the cnl::multiprecision alias - tests in index.cpp now reflect this are are generally tidied up - cleaner `using` directives - makes use of cnl::multiprecision - all the digit counts now add up
johnmcfarlane
force-pushed
the
signed_multiprecision_used_bits
branch
from
22f1152
to
a269337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #67