Fix logic error in save_file() #90
Comments
|
Does the error still happen with the last month's commit (8274df4)? |
I used gitup from recent ports, so yes, still fails and the patch helps. |
|
I haven't tagged the latest commit yet (sorry about that). Could you please clone the latest commit and give it a try? Thanks! |
|
Ports version has it all, I checked source with my eyes. Also take a look: |
|
I didn't see that the ports tree got a revision bump and included the latest commit without me tagging a new version number (sorry for the confusion on my part and the extra work on yours). Your patch is in and it should be fixed now. Thank you! |
ChangeLog: Fix logic error in save_file() johnmehr/gitup#90 MFH: 2023Q2
ChangeLog: Fix logic error in save_file() johnmehr/gitup#90 MFH: 2023Q2 (cherry picked from commit a5ba35b)
Latest commit 8274df4 seems to be incomplete.
Recent import of llvm15 into FreeBSD source tree https://cgit.freebsd.org/src/commit/contrib/llvm-project/libcxx/include/__string?id=81ad626541db97eb356e2c1d4a20eb2a26a766ab changed contrib/llvm-project/libcxx/include/__string from plain file to a directory and gitup fails to repair or update local tree that pre-dates noted import with error:
save_file: write file failure /usr/src/contrib/llvm-project/libcxx/include/__string/char_traits.h: Not a directory
Attached patch fixes the problem. It verifies if last component of path containing file is really directory and removes it otherwise then recreates the path.
patch-gitup.c.txt
The text was updated successfully, but these errors were encountered: