Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-detect path to Xcode.app #56

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Auto-detect path to Xcode.app #56

merged 5 commits into from
Jul 22, 2022

Conversation

johnno1962
Copy link
Owner

No description provided.

@leonidmelnyk
Copy link

Nice approach! The code is more interesting than I proposed 👍
Still there is a couple changed which I would include in the PR:

@leonidmelnyk leonidmelnyk mentioned this pull request Jul 21, 2022
Closed
@johnno1962
Copy link
Owner Author

You're right, I've removed the alert now which is a big step forward. As for the other change to build_bundles.sh, I'd prefer that you need a valid Xcode.app in /Applications to be able to build InjectionIII for the path checks to work though they are nearly no longer necessary.

@johnno1962 johnno1962 requested a review from zenangst July 21, 2022 20:04
@johnno1962 johnno1962 force-pushed the auto-xcode-dev branch 2 times, most recently from 0953955 to 4993cea Compare July 22, 2022 02:06
@johnno1962 johnno1962 merged commit dcf0c0d into main Jul 22, 2022
johnno1962 added a commit that referenced this pull request Jul 22, 2022
@johnno1962
Auto-detect path to Xcode.app (#56)
bd21ced
@davidbalbert davidbalbert mentioned this pull request Aug 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenangst zenangst Awaiting requested review from zenangst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnno1962 @leonidmelnyk