Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_snake_case on multiple word keys #13

Closed
jeremyjh opened this issue Jan 31, 2018 · 0 comments · Fixed by #25
Closed

to_snake_case on multiple word keys #13

jeremyjh opened this issue Jan 31, 2018 · 0 comments · Fixed by #25

Comments

@jeremyjh
Copy link

I'm pretty sure no one expects underscores to be inserted in separate words. I actually think to_snake_case should only update keys that are in camelCase or PascalCase. Separate words are more likely to be a title, and should not be modified at all.

ProperCase.to_snake_case(%{"Multi Word Keys" => "some value"})
%{"multi _word _keys" => "some value"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant