Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save chat history on db and remove faker #5

Closed
adalenv opened this issue Mar 16, 2018 · 8 comments
Closed

save chat history on db and remove faker #5

adalenv opened this issue Mar 16, 2018 · 8 comments
Labels
enhancement possible feature Have to sleep over it

Comments

@adalenv
Copy link

adalenv commented Mar 16, 2018

No description provided.

@johnnymast johnnymast added enhancement possible feature Have to sleep over it labels Mar 16, 2018
@johnnymast johnnymast added this to the 1.3 milestone Mar 16, 2018
@johnnymast
Copy link
Owner

Hey @adalenv,

Actually i think faker could be moved to a dev dependentie instead of a real dependentie. As for the database part. It could be a good new feature.

@adalenv
Copy link
Author

adalenv commented Mar 16, 2018

yes
i will work on design

@johnnymast
Copy link
Owner

If you want to make it your self i will accept pr's

@adalenv
Copy link
Author

adalenv commented Mar 16, 2018

done

@johnnymast
Copy link
Owner

New versions will be.

Faker 1.7.1
cboden/ratchet v0.4.1

Im not move Faker to dev requirement. This is because this project is a skeleton and if you create a new project from this skeleton it will probably not install Faker winch crashes the server (not 100% sure).

@johnnymast
Copy link
Owner

If you wish to help you can test the 1.3 branch with new features. See this list
https://github.com/johnnymast/mysql_websocket_chat/blob/1.3/CHANELOG.md

@adalenv
Copy link
Author

adalenv commented Jun 6, 2018

its released?

@johnnymast
Copy link
Owner

johnnymast commented Jun 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement possible feature Have to sleep over it
Projects
None yet
Development

No branches or pull requests

2 participants