Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bail entirely when you can't resolve an asset #5

Merged
merged 1 commit into from
Sep 23, 2014

Conversation

mikeatlas
Copy link
Contributor

Calling return in an each loop exits the entire erb compilation. The loop should next if it can't stat or raises a Sprockets::FileNotFound exception. Otherwise one bad asset causes the whole script to fail.

johnnypez added a commit that referenced this pull request Sep 23, 2014
Don't bail entirely when you can't resolve an asset
@johnnypez johnnypez merged commit 97e1026 into johnnypez:master Sep 23, 2014
@mikeatlas
Copy link
Contributor Author

Thanks!

@johnnypez
Copy link
Owner

No problem, thanks for the PR.

On 23 September 2014 15:59, Mike Atlas notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#5 (comment).

  • John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants