Add support for webpack 5 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangchunn
reviewed
Dec 24, 2018
package.json
Outdated
| @@ -27,15 +27,19 @@ | |||
| "url": "https://github.com/johnnyreilly/fork-ts-checker-notifier-webpack-plugin/issues" | |||
| }, | |||
| "dependencies": { | |||
| "fork-ts-checker-webpack-plugin": "^1.0.0-alpha.0", | |||
There was a problem hiding this comment.
I feel like this should be moved into peerDependencies instead. Reasoning is that a user might want a different version of fTCWP, and the user can override fTCNWP's tTCWP version.
There was a problem hiding this comment.
It's now listed as a devDependency of:
"fork-ts-checker-webpack-plugin": "^1.0.0-alpha.1",
and a peerDependency of:
"fork-ts-checker-webpack-plugin": "*"
Sound about right?
There was a problem hiding this comment.
We might want to use something like 1.x or ^1.0.0 since this upgrade won’t support fTCWP below 1.0
There was a problem hiding this comment.
Good shout - just pushed. Any other thoughts before I publish an alpha?
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the advice given by @liangchunn here: TypeStrong/fork-ts-checker-webpack-plugin#166