Major update #4
Merged
Major update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show SUCCESS message even when there are excluded warnings. - Show basename instead of the full path. - Updated messages. - Simplified code.
johnnyreilly
reviewed
Sep 1, 2018
index.js
Outdated
| title: util.format('%sType check succeeded', this.titlePrefix), | ||
| message: util.format( | ||
| '%s%s', | ||
| 'Not type errors found.', |
There was a problem hiding this comment.
Could this be 'No type errors!' please? It's chirpier 馃榿
There was a problem hiding this comment.
Sure. "not" is obviously a typo.
|
Thanks for the PR! I'm on my phone right now but I'll try and take a proper look when next at a laptop |
|
FWIW I feel shame I still haven't written tests for this package 馃槰 |
|
@johnnyreilly At least there is an issues section 馃檪 |
|
Released with https://github.com/johnnyreilly/fork-ts-checker-notifier-webpack-plugin/releases/tag/v0.5.0 - thanks for your work! |
|
Baby steps of actually adding tests now 馃槃 |
|
Awesome ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no notification when build succeed with warnings and
excludeWarningswas set totrue.Full path was unusable as text was truncated and I never saw an actual filename (I'm on macOS).
"Build succeeded" was quite misleading as notification can fire before webpack emits files, especially in first build.
I slightly updated a code to make it more straightforward 馃槈