Added support for RegularExpression, MaxLength, MinLength and FileExtensions attributes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension attributes to use the methods in jV Additional-Methods. Brought Test Project up to MVC 5.2.3 (to support MinLength, MaxLength) and added binding redirects to support this. TODO: Update Demo Project.
…sions attributes. Updated jVUNDemo to MVC 5.2.3 to use the adaptors in there for the attributes.
Closed
|
Cool - I'll try and take a look next week when I'm back near a computer. Ping me if I forget! |
|
This is a really high quality pull request @Zhaph - thanks so much! Merged with pleasure. |
johnnyreilly
added a commit
that referenced
this pull request
Jun 8, 2015
Added support for RegularExpression, MaxLength, MinLength and FileExtensions attributes
|
I've fixed up a couple of typos in the text, published to NuGet and given you a credit in the change log and the docs. Thanks again for the pull request Ben. It seems like we work pretty near to each other - I'm based in St James's and it sounds like you're pretty close by? |
|
No worries - and well spotted on my copy/pasted typos :S Glad to help, and thanks for all the work you'd put into this to start with. Based over in Shoreditch at the moment, so fairly close as these things go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the RegularExpression and FileExtension attributes aren't rendered correctly to support the out-of-the box validation methods in jV's additional-methods.js so I've added support for those.
I've also updated the Length support to also handle MinLength and MaxLength now that MVC 5.2.3 supports those attributes as well.
Tests and Demo's have also been updated (demo site in a separate commit).
Also noticed that the EqualTo test case was failing as you were no longer checking the custom error message.
I only updated the Demo & Test projects to MVC 5.2.3 as the core project didn't really need the additional dependency.