Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use f_auto,q_auto #5

Merged
merged 1 commit into from
Jan 13, 2023
Merged

feat: use f_auto,q_auto #5

merged 1 commit into from
Jan 13, 2023

Conversation

johnnyreilly
Copy link
Owner

@johnnyreilly johnnyreilly commented Jan 13, 2023

This PR implements usage of f_auto / q_auto - thanks to @rebeccapeltz for the suggestion!

f_auto causes Cloudinary to look at User Agent information in the request header and provides the best image format for the browser or device making the request. q_auto provides compression that makes the image smaller without creating pixelation.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@johnnyreilly johnnyreilly merged commit 6aa6492 into main Jan 13, 2023
@johnnyreilly johnnyreilly deleted the feat/f_auto-q_auto branch January 13, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant