Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title positioning on an iPad #83

Closed
hnarayanan opened this issue Oct 5, 2014 · 11 comments
Closed

Title positioning on an iPad #83

hnarayanan opened this issue Oct 5, 2014 · 11 comments

Comments

@hnarayanan
Copy link
Contributor

(I'm not sure if you're aware of this.) The position of the title when viewing Pixyll using Safari on an iPad doesn't responsively center, but the nav menu does, leading to the following effect:

img_0044

(Alternatively, the nav centers when it doesn't need to and the title stays in the right place.)

I am not sure how to debug this while sitting at my computer because the corresponding media queries work well here. Is there something you'd like me to try or information I could provide to help resolve this?

@johno
Copy link
Owner

johno commented Oct 5, 2014

Thanks a bunch for reporting this @hnarayanan !

I wasn't aware of this problem, so I greatly appreciate you taking the time to create this issue. I'll get digging into what's going on sometime today. I suspect that there's a specificity problem with .site-header .site-title.

As a side note, in case you wanted to get digging, you can use the web inspector with an iOS device for debugging if you follow the directions here. It's quite awesome.

@hnarayanan
Copy link
Contributor Author

Cool, thanks, I didn't know about this web inspector. Will dig deeper later today.

@johno
Copy link
Owner

johno commented Oct 6, 2014

Yeah, it's a life saver debugging these types of things.

@johno
Copy link
Owner

johno commented Oct 6, 2014

Just pushed a potential fix for this issue. However, I don't have an iPad on me to verify (I will check when I get home tonight).

@ankur-gupta
Copy link

I think this might help: http://mobiletest.me/

@hnarayanan
Copy link
Contributor Author

Yes, I checked it now and it works (in that both the title and the navigation menu are centered)!
But as I mentioned below the initial screenshot, it appears as though there is enough horizontal space to keep the title on the left and the navigation menu on the right when in portrait on an iPad.

Will post a screenshot soon of how it looks now.

@hnarayanan
Copy link
Contributor Author

img_0045

@johno
Copy link
Owner

johno commented Oct 6, 2014

Thanks @ankur-gupta ! http://mobiletest.me is pretty rad.

@johno
Copy link
Owner

johno commented Oct 6, 2014

The reason why it toggles to the centered mode a little early is to account for nav menus that have 4-5 links in them, as they'd blow out the alotted area.

The Pixyll menu just doesn't really take advantage for that since it's only got two links.

@hnarayanan
Copy link
Contributor Author

I understand and agree. Thank you for being so responsive with this change.

@johno
Copy link
Owner

johno commented Oct 6, 2014

🍻 !

@johno johno closed this as completed Oct 6, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants